test(source): refactor upsert avro tests #17044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9 tasks
xxchan
force-pushed
the
05-31-test_source_refactor_upsert_avro_tests
branch
from
274245b to
b9d8937
Compare
9 tasks
xxchan
commented
May 31, 2024
Comment on lines
+39
to
+48
| # TODO: Uncomment this when we add test data kafka key with format `"ID":id` | ||
| # statement ok | ||
| # CREATE TABLE upsert_avro_json ( | ||
| # PRIMARY KEY("ID") | ||
| # ) | ||
| # WITH ( | ||
| # connector = 'kafka', | ||
| # properties.bootstrap.server = '${RISEDEV_KAFKA_BOOTSTRAP_SERVERS}', | ||
| # topic = 'upsert_avro_json') | ||
| # FORMAT UPSERT ENCODE AVRO (schema.registry = '${RISEDEV_SCHEMA_REGISTRY_URL}'); |
There was a problem hiding this comment.
I don't actually understand what's the commented test mean. Just kept it
There was a problem hiding this comment.
We used to parse kafka key with Json format. That's why it required the key looks like "ID": id. But now we parse kafka key as bytes, so I think we can uncomment this now.
xxchan
force-pushed
the
05-31-test_source_refactor_upsert_avro_tests
branch
from
2347104 to
4d34ffc
Compare
xxchan
force-pushed
the
05-31-test_source_refactor_upsert_avro_tests
branch
from
4d34ffc to
4c9169b
Compare
xxchan
changed the base branch from
05-30-refactor_source_refactor_access
to
main
xxchan
requested review from
BugenZhao,
tabVersion and
xiangjinwu
and removed request for
a team
tabVersion
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
source_inlineand use risedev env vars to be easier to run locallyChecklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.