Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(expr): type-safe infallible evaluation #12921

Merged
merged 9 commits into from
Oct 24, 2023

Merge branch 'main' into bz/type-safe-infallible-evaluation

f47cd7e
Select commit
Loading
Failed to load commit list.
Merged

refactor(expr): type-safe infallible evaluation #12921

Merge branch 'main' into bz/type-safe-infallible-evaluation
f47cd7e
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2023-10-24 09:12:37 ago

3 / 4 tasks completed

1 task still to be completed

Details

Required Tasks

Task Status
I have written necessary rustdoc comments Completed
I have added necessary unit tests and integration tests Completed
All checks passed in ./risedev check (or alias, ./risedev c) Completed
My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users) Incomplete
Users may construct a NonStrictExpression in-place at any time with new_topmost. In this case, the inner will be a reference with lifetime. Incomplete
However, in most of time it's an owned type stored in the executors. So giving a default type parameter makes it less verbose. Incomplete