-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(expr): type-safe infallible evaluation #12921
Conversation
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
10dd303
to
9edb4cc
Compare
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #12921 +/- ##
==========================================
- Coverage 68.70% 68.64% -0.07%
==========================================
Files 1495 1495
Lines 251092 251134 +42
==========================================
- Hits 172521 172380 -141
- Misses 78571 78754 +183
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 20 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
Signed-off-by: Bugen Zhao [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Introduce a type-safe wrapper
NonStrictExpression
indicating that we can safely (without panic) unwrap the evaluation result. It can either be constructed with non-strict build functions likebuild_non_strict_from_prost
, or withnew_topmost
that wraps the topmost expression node only as a TODO.To make this happen, we separate
boxed
into an extension trait to enable non-static expression implementations, so that we can callnew_topmost
with an expression reference.This is a follow-up of #12461 and preparation of #12474.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.