Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove connector node from risedev #12807

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Oct 12, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@chenzl25 chenzl25 marked this pull request as ready for review October 12, 2023 06:28
@kwannoel
Copy link
Contributor

Do we always want it to be part of compute-node? Are there any occasions we will want to deploy it separately?

@kwannoel kwannoel requested a review from fuyufjh October 12, 2023 06:39
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #12807 (0c6a1be) into main (ac2a58c) will decrease coverage by 0.05%.
Report is 6 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #12807      +/-   ##
==========================================
- Coverage   69.27%   69.22%   -0.05%     
==========================================
  Files        1483     1482       -1     
  Lines      243819   243771      -48     
==========================================
- Hits       168894   168742     -152     
- Misses      74925    75029     +104     
Flag Coverage Δ
rust 69.22% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/risedevtool/src/bin/risedev-compose.rs 0.00% <ø> (ø)
src/risedevtool/src/bin/risedev-dev.rs 0.00% <ø> (ø)
src/risedevtool/src/config.rs 0.00% <ø> (ø)
src/risedevtool/src/config_gen/prometheus_gen.rs 0.00% <ø> (ø)
src/risedevtool/src/service_config.rs 0.00% <ø> (ø)
src/risedevtool/src/task.rs 0.00% <ø> (ø)
src/meta/src/lib.rs 0.00% <0.00%> (ø)

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@neverchanje
Copy link
Contributor

Are there any occasions we will want to deploy it separately?

Let's keep them coupled until we see a real value for separation.

@chenzl25
Copy link
Contributor Author

Do we always want it to be part of compute-node? Are there any occasions we will want to deploy it separately?

We want to simplify our system architecture, so we won't deploy it separately. The cloud team will also remove it from the k8s later.

Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The part of removing connector-node LGTM

Copy link
Contributor

@kwannoel kwannoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing connector-node lgtm, since it is already part of CN.

Copy link
Contributor

@StrikeW StrikeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to also remove src/risedevtool/src/task/connector_service.rs
FYI: #6549

@chenzl25 chenzl25 mentioned this pull request Oct 12, 2023
14 tasks
@chenzl25 chenzl25 enabled auto-merge October 12, 2023 08:03
@chenzl25 chenzl25 added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit a36d3c0 Oct 12, 2023
7 of 9 checks passed
@chenzl25 chenzl25 deleted the dylan/remove_connector_node_from_risedev branch October 12, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants