-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove connector node from risedev #12807
Conversation
Do we always want it to be part of compute-node? Are there any occasions we will want to deploy it separately? |
Codecov Report
@@ Coverage Diff @@
## main #12807 +/- ##
==========================================
- Coverage 69.27% 69.22% -0.05%
==========================================
Files 1483 1482 -1
Lines 243819 243771 -48
==========================================
- Hits 168894 168742 -152
- Misses 74925 75029 +104
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Let's keep them coupled until we see a real value for separation. |
We want to simplify our system architecture, so we won't deploy it separately. The cloud team will also remove it from the k8s later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The part of removing connector-node LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing connector-node lgtm, since it is already part of CN.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may need to also remove src/risedevtool/src/task/connector_service.rs
FYI: #6549
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.