Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): connector node no-build-rust for docker #12804

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Oct 12, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@chenzl25 chenzl25 marked this pull request as ready for review October 12, 2023 05:32
@chenzl25 chenzl25 requested review from wenym1 and xxchan October 12, 2023 05:32
@chenzl25 chenzl25 requested review from yufansong and fuyufjh October 12, 2023 05:32
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #12804 (3d99768) into main (ac2a58c) will decrease coverage by 0.07%.
Report is 4 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #12804      +/-   ##
==========================================
- Coverage   69.27%   69.20%   -0.07%     
==========================================
  Files        1483     1483              
  Lines      243819   243825       +6     
==========================================
- Hits       168894   168732     -162     
- Misses      74925    75093     +168     
Flag Coverage Δ
rust 69.20% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/meta/src/lib.rs 0.00% <0.00%> (ø)

... and 17 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chenzl25 chenzl25 mentioned this pull request Oct 12, 2023
14 tasks
@chenzl25 chenzl25 added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit d472f5b Oct 12, 2023
10 of 11 checks passed
@chenzl25 chenzl25 deleted the dylan/no_build_rust_for_docker branch October 12, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants