Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): fix compact_fast_runner_bytes unused #12655

Merged
merged 3 commits into from
Oct 9, 2023
Merged

fix(storage): fix compact_fast_runner_bytes unused #12655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0a1b83
fix(storage): fix compact_fast_runner_bytes unused
Li0k Oct 7, 2023
f6eeb7f
fix(storage): address comments
Li0k Oct 8, 2023
a97e0af
Merge branch 'main' of https://github.com/risingwavelabs/risingwave i…
Li0k Oct 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions src/storage/src/hummock/compactor/compactor_runner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,17 +433,17 @@ pub async fn compact(
) * compact_task.splits.len() as u64;

tracing::info!(
"Ready to handle compaction group {} task: {} compact_task_statistics {:?} target_level {} compression_algorithm {:?} table_ids {:?} parallelism {} task_memory_capacity_with_parallelism {}, enable fast runner: {}",
compact_task.compaction_group_id,
compact_task.task_id,
compact_task_statistics,
compact_task.target_level,
compact_task.compression_algorithm,
compact_task.existing_table_ids,
parallelism,
task_memory_capacity_with_parallelism,
optimize_by_copy_block
);
"Ready to handle compaction group {} task: {} compact_task_statistics {:?} target_level {} compression_algorithm {:?} table_ids {:?} parallelism {} task_memory_capacity_with_parallelism {}, enable fast runner: {}",
compact_task.compaction_group_id,
compact_task.task_id,
compact_task_statistics,
compact_task.target_level,
compact_task.compression_algorithm,
compact_task.existing_table_ids,
parallelism,
task_memory_capacity_with_parallelism,
optimize_by_copy_block
);

// If the task does not have enough memory, it should cancel the task and let the meta
// reschedule it, so that it does not occupy the compactor's resources.
Expand Down
2 changes: 1 addition & 1 deletion src/storage/src/hummock/compactor/fast_compactor_runner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ impl CompactorRunner {
total_read_bytes += sst.file_size;
}
self.metrics
.write_build_l0_bytes
.compact_fast_runner_bytes
.inc_by(skip_raw_block_size);
tracing::info!(
"OPTIMIZATION: skip {} blocks for task-{}, optimize {}% data compression",
Expand Down
Loading