Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): fix compact_fast_runner_bytes unused #12655

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

Li0k
Copy link
Contributor

@Li0k Li0k commented Oct 7, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Oct 7, 2023
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #12655 (a97e0af) into main (129ab28) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 8.33%.

@@           Coverage Diff           @@
##             main   #12655   +/-   ##
=======================================
  Coverage   69.32%   69.33%           
=======================================
  Files        1470     1470           
  Lines      241541   241541           
=======================================
+ Hits       167448   167469   +21     
+ Misses      74093    74072   -21     
Flag Coverage Δ
rust 69.33% <8.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...age/src/hummock/compactor/fast_compactor_runner.rs 92.09% <100.00%> (ø)
.../storage/src/hummock/compactor/compactor_runner.rs 79.48% <0.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Little-Wallace Little-Wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a mistake. This metrics shall be used in compactor::fast_compactor_runner::L485, but I write it to write_build_l0_bytes. So you only need to replace it.

@Li0k Li0k enabled auto-merge October 8, 2023 09:12
@Li0k
Copy link
Contributor Author

Li0k commented Oct 8, 2023

I made a mistake. This metrics shall be used in compactor::fast_compactor_runner::L485, but I write it to write_build_l0_bytes. So you only need to replace it.

Thanks, fix it now

@Li0k Li0k added this pull request to the merge queue Oct 9, 2023
Merged via the queue into main with commit 31cf3f8 Oct 9, 2023
7 of 8 checks passed
@Li0k Li0k deleted the li0k/storage_fast_compact_metrics branch October 9, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants