Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: risedev clean java targets #12600

Merged
merged 2 commits into from
Oct 6, 2023
Merged

chore: risedev clean java targets #12600

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56819eb
chore: risedev clean java targets
fuyufjh Oct 2, 2023
3fca255
improve
fuyufjh Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Makefile.toml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the condition for the task is condition = { env_set = ["ENABLE_BUILD_RUST"] }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add if $ENABLE_BUILD_RW_CONNECTOR or sth?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored

Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,15 @@ script = '''
#!/usr/bin/env bash
set -e
cargo clean

if command -v mvn &> /dev/null; then
MAVEN_PATH="$(command -v mvn)"
else
MAVEN_PATH="${PREFIX_BIN}/maven/bin/mvn"
fi

cd "${JAVA_DIR}"
"${MAVEN_PATH}" clean
'''

[tasks.build-docs]
Expand Down
Loading