Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: risedev clean java targets #12600

Merged
merged 2 commits into from
Oct 6, 2023
Merged

chore: risedev clean java targets #12600

merged 2 commits into from
Oct 6, 2023

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Oct 2, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #12600 (3fca255) into main (a8f21ed) will decrease coverage by 0.01%.
Report is 20 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #12600      +/-   ##
==========================================
- Coverage   69.30%   69.30%   -0.01%     
==========================================
  Files        1469     1469              
  Lines      241061   241061              
==========================================
- Hits       167072   167069       -3     
- Misses      73989    73992       +3     
Flag Coverage Δ
rust 69.30% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fuyufjh fuyufjh requested review from BugenZhao and xxchan October 5, 2023 06:29
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the condition for the task is condition = { env_set = ["ENABLE_BUILD_RUST"] }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add if $ENABLE_BUILD_RW_CONNECTOR or sth?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored

@fuyufjh fuyufjh requested a review from xxchan October 5, 2023 09:19
@xxchan xxchan added this pull request to the merge queue Oct 6, 2023
Merged via the queue into main with commit 7b8c696 Oct 6, 2023
6 of 7 checks passed
@xxchan xxchan deleted the eric/chore_risedev_clean branch October 6, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants