Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(streaming): persist row_count in backfill state_table #12415

Merged
merged 13 commits into from
Sep 22, 2023

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Sep 19, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

We have to persist the back-filled row count somehow, so that after recovery we can still report the ddl progress.
We store it in the backfill's state_table in this PR, and recover it from there as well.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel kwannoel added ci/run-backwards-compat-tests Run backwards compatibility tests in your PR. ci/run-backfill-tests labels Sep 19, 2023
@kwannoel kwannoel force-pushed the kwannoel/backfill-row-count branch from 22dc7e7 to 9dcf6f2 Compare September 19, 2023 06:58
@kwannoel kwannoel force-pushed the kwannoel/backfill-row-count branch from 7d9ac76 to bd13246 Compare September 20, 2023 02:46
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #12415 (f4a55c8) into main (c9b356a) will decrease coverage by 0.02%.
Report is 20 commits behind head on main.
The diff coverage is 10.34%.

@@            Coverage Diff             @@
##             main   #12415      +/-   ##
==========================================
- Coverage   69.61%   69.60%   -0.02%     
==========================================
  Files        1424     1424              
  Lines      236554   236608      +54     
==========================================
+ Hits       164677   164683       +6     
- Misses      71877    71925      +48     
Flag Coverage Δ
rust 69.60% <10.34%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...tream/src/executor/backfill/no_shuffle_backfill.rs 0.00% <0.00%> (ø)
src/stream/src/executor/backfill/utils.rs 8.82% <0.00%> (-0.76%) ⬇️
src/stream/src/task/barrier_manager/progress.rs 54.92% <ø> (ø)
...ntend/src/optimizer/plan_node/stream_table_scan.rs 98.64% <100.00%> (+0.03%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kwannoel kwannoel force-pushed the kwannoel/backfill-row-count branch 2 times, most recently from 415bd3a to 2895fd0 Compare September 20, 2023 05:56
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwannoel kwannoel force-pushed the kwannoel/backfill-row-count branch from 2895fd0 to 55e4f5a Compare September 20, 2023 06:30
@kwannoel kwannoel enabled auto-merge September 22, 2023 03:25
@kwannoel kwannoel disabled auto-merge September 22, 2023 03:26
@kwannoel kwannoel enabled auto-merge September 22, 2023 03:33
@kwannoel kwannoel added this pull request to the merge queue Sep 22, 2023
Merged via the queue into main with commit d7cb2ae Sep 22, 2023
6 of 7 checks passed
@kwannoel kwannoel deleted the kwannoel/backfill-row-count branch September 22, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants