-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(streaming): persist row_count in backfill state_table #12415
Conversation
22dc7e7
to
9dcf6f2
Compare
7d9ac76
to
bd13246
Compare
Codecov Report
@@ Coverage Diff @@
## main #12415 +/- ##
==========================================
- Coverage 69.61% 69.60% -0.02%
==========================================
Files 1424 1424
Lines 236554 236608 +54
==========================================
+ Hits 164677 164683 +6
- Misses 71877 71925 +48
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
415bd3a
to
2895fd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- add row count
- we just dynamically check row_length with state length
2895fd0
to
55e4f5a
Compare
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
We have to persist the back-filled row count somehow, so that after recovery we can still report the ddl progress.
We store it in the backfill's state_table in this PR, and recover it from there as well.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.