Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stream): support row count for arrangement backfill #14836

Merged
merged 12 commits into from
Jan 30, 2024

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Jan 29, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Supports recoverable row count for arrangement backfill. We will persist and recover it.

It's to ensure that arrangement backfill remains compatible with background ddl. We must persist the row count so that after recovery, we can recover the estimated progress for the materialized view in show jobs.

The meta-side logic is the same as with NoShuffleBackfill, after recovery, meta will receive updates from NoShuffleBackfill executors to reconstruct the progress bar.

Progress is calculated with: total_snapshot_row_count / total_upstream_row_count in meta.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@BugenZhao
Copy link
Member

Can you elaborate more on the motivation?

@kwannoel
Copy link
Contributor Author

Can you elaborate more on the motivation?

Updated

@kwannoel kwannoel force-pushed the kwannoel/support-row-count branch from 9111074 to b3397f2 Compare January 30, 2024 00:53
@kwannoel
Copy link
Contributor Author

Only e2e test (release) failed as expected. It failed in today's main-cron as well.

@kwannoel
Copy link
Contributor Author

Any comments @BugenZhao @chenzl25 ?

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems I missed something. Prior to this PR, how do we recover the progress (bar) for background no-shuffle backfill?

@kwannoel
Copy link
Contributor Author

kwannoel commented Jan 30, 2024

Seems I missed something. Prior to this PR, how do we recover the progress (bar) for background no-shuffle backfill?

There are several PRs which would commit the row count state to the state table for background no shuffle:

@kwannoel kwannoel added this pull request to the merge queue Jan 30, 2024
@BugenZhao
Copy link
Member

There are several PRs which would commit the row count state to the state table for background no shuffle:

I see. I once thought the changes in utils would be shared by no-shuffle backfill and arrangement backfill, but it seems not.

@kwannoel
Copy link
Contributor Author

There are several PRs which would commit the row count state to the state table for background no shuffle:

I see. I once thought the changes in utils would be shared by no-shuffle backfill and arrangement backfill, but it seems not.

Perhaps it is possible. I chose not to do so for now, because arrangement backfill's logic is per vnode in comparison the no shuffle backfill.

We can refactor it in the future.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2024
@kwannoel kwannoel force-pushed the kwannoel/support-row-count branch from 2b88ac5 to 95f3f00 Compare January 30, 2024 05:51
@kwannoel kwannoel added this pull request to the merge queue Jan 30, 2024
Merged via the queue into main with commit 63e5485 Jan 30, 2024
27 of 29 checks passed
@kwannoel kwannoel deleted the kwannoel/support-row-count branch January 30, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants