-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stream): support row count for arrangement backfill #14836
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
ca366e6
to
9073a6f
Compare
Can you elaborate more on the motivation? |
Updated |
9111074
to
b3397f2
Compare
Only e2e test (release) failed as expected. It failed in today's main-cron as well. |
Any comments @BugenZhao @chenzl25 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems I missed something. Prior to this PR, how do we recover the progress (bar) for background no-shuffle backfill?
There are several PRs which would commit the row count state to the state table for background no shuffle:
|
I see. I once thought the changes in |
Perhaps it is possible. I chose not to do so for now, because arrangement backfill's logic is per vnode in comparison the no shuffle backfill. We can refactor it in the future. |
Co-authored-by: August <[email protected]>
Co-authored-by: August <[email protected]>
2b88ac5
to
95f3f00
Compare
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Supports recoverable row count for arrangement backfill. We will persist and recover it.
It's to ensure that arrangement backfill remains compatible with background ddl. We must persist the row count so that after recovery, we can recover the estimated progress for the materialized view in
show jobs
.The meta-side logic is the same as with
NoShuffleBackfill
, after recovery, meta will receive updates fromNoShuffleBackfill
executors to reconstruct the progress bar.Progress is calculated with:
total_snapshot_row_count / total_upstream_row_count
in meta.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.