Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): prune tests which should run occasionally #12233

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Sep 12, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Closes #11879.

Save CI costs and make it more stable.

Pruned 8 tests (iceberg sink tests share a common label, java connector node tests share a common label).

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel
Copy link
Contributor Author

kwannoel commented Sep 12, 2023

@wenym1 @xxhZs @ZENOTME @wcy-fdu @BugenZhao @yufansong PTAL, since I think it will affect your tests. I will not merge it if it is too disruptive to your workflows.

After this PR to run these tests, simply add the relevant labels (github will autocomplete it), as seen in this PR:

Screenshot 2023-09-12 at 5 54 47 PM

Screenshot 2023-09-12 at 8 15 57 PM

I have also ported any tests not ran per PR to main-cron.

@kwannoel kwannoel requested a review from wcy-fdu September 12, 2023 09:45
@kwannoel kwannoel force-pushed the kwannoel/prune-tests branch from ddb3ff3 to 9de8d57 Compare September 13, 2023 02:13
@kwannoel kwannoel enabled auto-merge September 13, 2023 02:13
@kwannoel kwannoel disabled auto-merge September 13, 2023 02:22
@kwannoel kwannoel enabled auto-merge September 13, 2023 02:31
@kwannoel kwannoel added this pull request to the merge queue Sep 13, 2023
Merged via the queue into main with commit f8e0ce7 Sep 13, 2023
5 of 6 checks passed
@kwannoel kwannoel deleted the kwannoel/prune-tests branch September 13, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving CI costs by reducing tests run per PR
4 participants