-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sink): kafka upsert sink with schema #12113
Conversation
Codecov Report
@@ Coverage Diff @@
## main #12113 +/- ##
==========================================
+ Coverage 69.18% 69.20% +0.01%
==========================================
Files 1489 1489
Lines 245832 246057 +225
==========================================
+ Hits 170083 170281 +198
- Misses 75749 75776 +27
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sorry for the huge conflict due to the refactor. Just to share some thoughts: it looks like this change
Given these, after the refactor, this change may be done in |
updated @xiangjinwu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also fix the test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tabVersion to check if your comments are resolved
LGTM |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add an option
schemas.enable
for kafka upsert sink to output with schema that is supported by kafka connect'sjsonconverter
.Syntax:
Details:
avro
orprotobuf
but onlyjson
. Furthermore, it is mutual exclusive with usage of schema registry containing json schema (io.confluent.connect.json.JsonSchemaConverter
) and should not be confused with it. This option mimics the behavior oforg.apache.kafka.connect.json.JsonConverter
instead.upsert
for now and defaults tofalse
when unspecified. It will be extended to be available indebezium
and defaults totrue
.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.