Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stream): clear upstream buffer if no snapshot progress #11625

Merged
merged 1 commit into from
Aug 11, 2023
Merged

fix(stream): clear upstream buffer if no snapshot progress #11625

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/stream/src/executor/backfill/no_shuffle_backfill.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ where
// Consume upstream buffer chunk
// If no current_pos, means we did not process any snapshot
// yet. In that case
// we can just ignore the upstream buffer chunk.
// we can just ignore the upstream buffer chunk, but still need to clean it.
if let Some(current_pos) = &current_pos {
for chunk in upstream_chunk_buffer.drain(..) {
cur_barrier_upstream_processed_rows += chunk.cardinality() as u64;
Expand All @@ -370,6 +370,8 @@ where
&self.output_indices,
));
}
} else {
upstream_chunk_buffer.clear()
}

self.metrics
Expand Down