-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stream): clear upstream buffer if no snapshot progress #11625
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #11625 +/- ##
==========================================
- Coverage 70.30% 70.30% -0.01%
==========================================
Files 1359 1359
Lines 227141 227141
==========================================
- Hits 159694 159690 -4
- Misses 67447 67451 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As per title. Thanks to @Little-Wallace for discovering and reporting this bug. Found in #11398.
The observation was that multiple rows with the same PK were inserted into upstream mview.
Consider the following sequence of events:
pk=123
. -------> Upstream buffer containspk=123
123
.pk=123
to downstream.Then we will have inconsistent table.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note