Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: naming convention of session variables #13265

Closed
BugenZhao opened this issue Nov 6, 2023 · 6 comments · Fixed by #18769
Closed

Discussion: naming convention of session variables #13265

BugenZhao opened this issue Nov 6, 2023 · 6 comments · Fixed by #18769

Comments

@BugenZhao
Copy link
Member

BugenZhao commented Nov 6, 2023

off-topic: We should really review the naming of these variables. 😕

  • Some are prefixed with RW while others are not.
  • Some are prefixed with STREAMING (or BATCH) while others are not.

For example, why SINK_DECOUPLE but not RW_STREAMING_SINK_DECOUPLE?

Originally posted by @BugenZhao in #13262 (comment)

@github-actions github-actions bot added this to the release-1.5 milestone Nov 6, 2023
@TennyZhuang
Copy link
Contributor

We need to unify them, but before that, we have to introduce session variable alias to keep backward compatibility.

@fuyufjh fuyufjh removed this from the release-1.5 milestone Dec 6, 2023
@fuyufjh
Copy link
Member

fuyufjh commented Dec 6, 2023

Sounds good to me. Can you take a look? @yuhao-su

@yuhao-su
Copy link
Contributor

yuhao-su commented Dec 6, 2023

Do we have any conclusion about what is the name convention?

@fuyufjh
Copy link
Member

fuyufjh commented Dec 6, 2023

Do we have any conclusion about what is the name convention?

Indeed. Not yet, I guess.

Personally, I prefer the ones without RW_ prefix, because most session variables are specific to RW, and we don't plan to port many session variables from PG.

As for STREAMING/BATCH, I think it's optional and depends on the specific variables.

@fuyufjh fuyufjh changed the title unify the naming of session variables Discussion: naming convention of session variables Dec 6, 2023
Copy link
Contributor

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.

@xxchan
Copy link
Member

xxchan commented Sep 30, 2024

Maybe we should prioritize. I feel very confused and don't know which one to choose when I want to add a new config in #18749 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants