-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussion: naming convention of session variables #13265
Comments
We need to unify them, but before that, we have to introduce session variable alias to keep backward compatibility. |
Sounds good to me. Can you take a look? @yuhao-su |
Do we have any conclusion about what is the name convention? |
Indeed. Not yet, I guess. Personally, I prefer the ones without As for |
This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned. |
Maybe we should prioritize. I feel very confused and don't know which one to choose when I want to add a new config in #18749 🤣 |
off-topic: We should really review the naming of these variables. 😕
RW
while others are not.STREAMING
(orBATCH
) while others are not.For example, why
SINK_DECOUPLE
but notRW_STREAMING_SINK_DECOUPLE
?Originally posted by @BugenZhao in #13262 (comment)
The text was updated successfully, but these errors were encountered: