Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(session_config): allow add alias for parameter name #13963

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

yuhao-su
Copy link
Contributor

@yuhao-su yuhao-su commented Dec 13, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#13265

  • allow adding alias for parameter name

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a8f1fb5) 68.11% compared to head (65d5510) 68.03%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13963      +/-   ##
==========================================
- Coverage   68.11%   68.03%   -0.08%     
==========================================
  Files        1533     1533              
  Lines      264532   264560      +28     
==========================================
- Hits       180173   179987     -186     
- Misses      84359    84573     +214     
Flag Coverage Δ
rust 68.03% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/common/proc_macro/src/session_config.rs Outdated Show resolved Hide resolved
@yuhao-su yuhao-su enabled auto-merge December 13, 2023 08:02
@yuhao-su yuhao-su added this pull request to the merge queue Dec 13, 2023
Merged via the queue into main with commit 05c40b1 Dec 13, 2023
26 of 27 checks passed
@yuhao-su yuhao-su deleted the yuhao/config_param_name_compability branch December 13, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants