Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove prefix "rw_" in session variables #18769

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Sep 30, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Remove prefix "rw_" in session variables. fix #13265

Previous variables are still kept as aliases.

All changed variables:

  • rw_implicit_flush
  • rw_batch_enable_lookup_join
  • rw_batch_enable_sort_agg
  • rw_streaming_enable_delta_join
  • rw_streaming_enable_bushy_join
  • rw_streaming_allow_jsonb_in_stream_key
  • rw_enable_join_ordering
  • rw_enable_two_phase_agg
  • rw_force_two_phase_agg
  • rw_enable_share_plan
  • rw_force_split_distinct_agg
  • rw_streaming_over_window_cache_policy
  • rw_enable_shared_source

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

Signed-off-by: xxchan <[email protected]>
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also summarize the naming convention?

@xxchan
Copy link
Member Author

xxchan commented Oct 1, 2024

Personally, I prefer the ones without RW_ prefix, because most session variables are specific to RW, and we don't plan to port many session variables from PG.

As for STREAMING/BATCH, I think it's optional and depends on the specific variables.

Originally posted by @fuyufjh in #13265 (comment)

@xxchan xxchan added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit c359bd9 Oct 8, 2024
30 of 31 checks passed
@xxchan xxchan deleted the xxchan/session-var branch October 8, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discussion: naming convention of session variables
4 participants