Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Risingwave manifest for SQLite as meta store and local disk as storage #769

Merged

Conversation

vmaksimovski
Copy link
Contributor

What's changed and what's your intention?

Added a manifest that's really easy to use -- just sqlite and local disk. Very easy for folks to POC to.

I replicated risingwave-sqlite-s3 and risingwave-etcd-local-disk. I made the version in 2.1.0

Checklist

  • I have written the necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@vmaksimovski vmaksimovski requested a review from a team as a code owner December 11, 2024 19:07
@arkbriar
Copy link
Collaborator

The test failed because of some deleted files. I opened a PR to fix it. Let's rebase the PR onto main once it's merged.

Copy link
Collaborator

@arkbriar arkbriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot!

@arkbriar arkbriar enabled auto-merge December 23, 2024 13:03
@arkbriar arkbriar added this pull request to the merge queue Dec 23, 2024
Merged via the queue into risingwavelabs:main with commit 90fa212 Dec 23, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants