Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Risingwave manifest for SQLite as meta store and local disk as storage #768

Conversation

vmaksimovski
Copy link
Contributor

What's changed and what's your intention?

Added a manifest that's really easy to use -- just sqlite and local disk. Very easy for folks to POC to.

I replicated risingwave-sqlite-s3 and risingwave-etcd-local-disk. I made the version in 2.1.0

Checklist

  • I have written the necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@vmaksimovski vmaksimovski requested a review from a team as a code owner December 9, 2024 06:36
@vmaksimovski vmaksimovski marked this pull request as draft December 9, 2024 07:23
Copy link
Collaborator

@arkbriar arkbriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @vmaksimovski!

@arkbriar
Copy link
Collaborator

#765 will introduce the v2.1.0 to the examples and let's have this merged after it!

@vmaksimovski vmaksimovski changed the base branch from main to auto-update-v2.1.0 December 11, 2024 09:16
@vmaksimovski vmaksimovski marked this pull request as ready for review December 11, 2024 09:16
@arkbriar arkbriar deleted the branch risingwavelabs:auto-update-v2.1.0 December 11, 2024 10:05
@arkbriar arkbriar closed this Dec 11, 2024
@vmaksimovski
Copy link
Contributor Author

Why was this PR closed @arkbriar? I updated the base branch to be auto-update-v2.1.0 so that we will only wait until that PR is merged #765

@arkbriar
Copy link
Collaborator

Why was this PR closed @arkbriar? I updated the base branch to be auto-update-v2.1.0 so that we will only wait until that PR is merged #765

I have no idea what happened though the events showed that I closed the PR 😢
I saw another PR here #769. Let's merge that instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants