Sync with template repository to add pre-commit checks and CI #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new pre-commit checker (`pre-commit install` to set up locally)
This was done automatically with `pre-commit run --all-files`.
andresag01
reviewed
Jan 29, 2024
| run: make all | ||
| env: | ||
| VERSION: v${{ github.event.inputs.version }} | ||
| REVMARK: ${{ github.event.inputs.revision_mark }} |
There was a problem hiding this comment.
This part, which pre-dates the PR, make me a little sad because the CI build that ends in the artifacts has the following version string in the title page: Version v, 2024-01-27:. In other words, VERSION and REVMARK end up being empty here. Is it possible to fix this somehow?
There was a problem hiding this comment.
I'm sure we can get a default from the the makefile. I'll look into this today
There was a problem hiding this comment.
Since this is unrelated to this PR I've file #72 and plan to address this separately.
Otherwise pre-commit will complain.
Now includes pre-commit instructions as well as a minor workflow update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future this will make it easier to add more pre-commit checks to ensure consistency.