Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version in GitHub actions generated PDF wrong #72

Closed
arichardson opened this issue Jan 29, 2024 · 0 comments · Fixed by #73
Closed

Version in GitHub actions generated PDF wrong #72

arichardson opened this issue Jan 29, 2024 · 0 comments · Fixed by #73

Comments

@arichardson
Copy link
Collaborator

See #68 (comment).

We need to avoid overriding the Makefile default if no actions parameters are passed.
This was referenced Jan 29, 2024
Merged
Merged
arichardson added a commit to arichardson/riscv-cheri that referenced this issue Jan 29, 2024
@arichardson
Don't override VERSION and REVMARK for default actions builds
2fa7e5f 
Fixes: riscv#72
arichardson added a commit to arichardson/riscv-docs-spec-template that referenced this issue Jan 29, 2024
@arichardson
Only override VERSION and REVMARK for manual GitHub Actions builds
dcab7f2 
For non-manual builds the "env" argument to the "Build Files" step will
set VERSION to "v" and REVMARK to the empty string which results in
the version of the PDF being incorrect. To avoid this problem use a
conditional step that updates $GITHUB_ENV for `workflow_dispatch` builds
instead of setting the variables unconditionally.

This PR also removes the Step <N> prefix to all the comments since it
does not add any explanatory value and makes it more difficult to update
the workflow file.

See riscv/riscv-cheri#72

Signed-off-by: Alex Richardson <[email protected]>
@arichardson arichardson mentioned this issue Jan 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't override VERSION and REVMARK for default actions builds arichardson/riscv-cheri
1 participant
@arichardson