Only override VERSION and REVMARK for manual GitHub Actions builds #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For non-manual builds the "env" argument to the "Build Files" step will set VERSION to "v" and REVMARK to the empty string which results in the version of the PDF being incorrect. To avoid this problem use a conditional step that updates $GITHUB_ENV for `workflow_dispatch` builds instead of setting the variables unconditionally. This PR also removes the Step <N> prefix to all the comments since it does not add any explanatory value and makes it more difficult to update the workflow file. See riscv/riscv-cheri#72 Signed-off-by: Alex Richardson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For non-manual builds the "env" argument to the "Build Files" step will set VERSION to "v" and REVMARK to the empty string which results in the version of the PDF being incorrect. To avoid this problem use a conditional step that updates $GITHUB_ENV for
workflow_dispatchbuilds instead of setting the variables unconditionally.This PR also removes the Step prefix to all the comments since it does not add any explanatory value and makes it more difficult to update the workflow file.
See riscv/riscv-cheri#72