Fix for issue 126: Bad ascii char in layout files #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Issue 126: bad character in ALF file generated from missing raw string identifier for python: r"\1" 2. Added dependency in Makefile on the gen_alf.py script 3. Added error message when the MAP ALF generator cannot be found
klingaard
changed the title
|
#close 126 |
Merged
|
Poke a little on this one -- I could be mean and force the merge, but I like an approval. (just added Kathlene and Arup) |
arupc
approved these changes
Dec 5, 2023
|
Thanks for the reminder and sorry for the delay. Pushing against a deadline here… I’ll have a quick look later tonight. -Peter Op 5 dec 2023 om 18:12 heeft arupc ***@***.***> het volgende geschreven:
@arupc approved this pull request.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: ***@***.***>
|
peter-d
reviewed
Dec 5, 2023
| sl_grp.addScheduleLine('.*lsu.lsu_inst_queue.lsu_inst_queue', ["LSU IQ[\1]"], mini_split=[80,20]) | ||
| sl_grp.addScheduleLine('.*lsu.replay_buffer.replay_buffer([0-9]+)', ["LSU Replay[\1]"], mini_split=[80,20]) | ||
| sl_grp.addScheduleLine('.*lsu.lsu_inst_queue.lsu_inst_queue([0-9]+)', [r"LSU IQ[\1]"], mini_split=[80,20]) | ||
| #sl_grp.addScheduleLine('.*lsu.replay_buffer.replay_buffer([0-9]+)', ["LSU Replay[\1]"], mini_split=[80,20]) |
There was a problem hiding this comment.
Is there a specific reason to remove the replay buffer here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a couple of things: