Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mon-ascii characters in the generated alf files that are checked in, for example in small_core.alf #126

Closed
klingaard opened this issue Nov 30, 2023 · 1 comment · Fixed by #127
Closed

Mon-ascii characters in the generated alf files that are checked in, for example in small_core.alf #126

klingaard opened this issue Nov 30, 2023 · 1 comment · Fixed by #127
Assignees
@klingaard
Labels
bug Something isn't working

Comments

@klingaard
Copy link
Collaborator

klingaard commented Nov 30, 2023 •
edited
Loading

From @peter-d :

          Hi Knute - I run into problems with this PR, seems there are some non-ascii characters in the generated alf files that are checked in, for example in `small_core.alf`:

image

On my end (WSL2 Ubuntu), this crashes the yaml parsing when you start the pipe viewer. I haven't been able to rerun the generate script without errors, it's not clear to me what sparta version it depends on exactly to work.

Originally posted by @peter-d in #107 (comment)
@klingaard klingaard changed the title Hi Knute - I run into problems with this PR, seems there are some non-ascii characters in the generated alf files that are checked in, for example in small_core.alf: Mon-ascii characters in the generated alf files that are checked in, for example in small_core.alf: Nov 30, 2023
@klingaard klingaard changed the title Mon-ascii characters in the generated alf files that are checked in, for example in small_core.alf: Mon-ascii characters in the generated alf files that are checked in, for example in small_core.alf Nov 30, 2023
@klingaard klingaard self-assigned this Nov 30, 2023
@klingaard klingaard added the bug Something isn't working label Nov 30, 2023
@klingaard
Copy link
Collaborator Author

klingaard commented Nov 30, 2023 •
edited by ghost
Loading

Found the issue -- for the group replacement string \1, missed telling python to interpret the string raw: r"\1"

@klingaard klingaard linked a pull request Nov 30, 2023 that will close this issue
Fix for issue 126: Bad ascii char in layout files #127
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klingaard klingaard

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for issue 126: Bad ascii char in layout files riscv-software-src/riscv-perf-model
1 participant
@klingaard