Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding L2Cache Model - new sparta Unit #114

Merged
merged 18 commits into from
Dec 6, 2023

Conversation

Kunal-Buch
Copy link
Contributor

@Kunal-Buch Kunal-Buch commented Nov 7, 2023

-> L2Cache can accept multiple requests from DCache and IL1.
-> Cache functional model used is SimpleDL1.
-> Configurable cache hit latency.
-> Misses are forwarded to BIU and kept are tracked in the local buffer.
-> Miss to the pending cacheline is not sent out to BIU.
-> Backpressure handling for BIU credits.
-> make regress clean.

Copy link
Collaborator

@klingaard klingaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About half way through... 😄

core/DCache.hpp Outdated Show resolved Hide resolved
core/LSU.hpp Outdated Show resolved Hide resolved
core/LSU.hpp Outdated Show resolved Hide resolved
core/MemoryAccessInfo.hpp Outdated Show resolved Hide resolved
core/MemoryAccessInfo.hpp Outdated Show resolved Hide resolved
mss/L2Cache.hpp Outdated Show resolved Hide resolved
mss/L2Cache.hpp Outdated Show resolved Hide resolved
mss/L2Cache.hpp Outdated Show resolved Hide resolved
mss/L2Cache.hpp Outdated Show resolved Hide resolved
mss/L2Cache.hpp Outdated Show resolved Hide resolved
mss/L2Cache.cpp Outdated Show resolved Hide resolved
mss/L2Cache.cpp Outdated Show resolved Hide resolved
mss/L2Cache.cpp Outdated Show resolved Hide resolved
@ghost ghost requested review from klingaard and arupc November 13, 2023 23:04
mss/L2Cache.cpp Show resolved Hide resolved
mss/L2Cache.cpp Outdated Show resolved Hide resolved
mss/L2Cache.cpp Outdated Show resolved Hide resolved
mss/L2Cache.cpp Outdated Show resolved Hide resolved
mss/L2Cache.cpp Outdated Show resolved Hide resolved
mss/L2Cache.cpp Outdated Show resolved Hide resolved
mss/L2Cache.cpp Outdated Show resolved Hide resolved
mss/L2Cache.cpp Outdated Show resolved Hide resolved
mss/L2Cache.cpp Show resolved Hide resolved
test/core/l2cache/L2SourceUnit.hpp Outdated Show resolved Hide resolved
@@ -202,12 +210,28 @@ olympia::CoreTopologySimple::CoreTopologySimple(){
"cpu.core*.lsu.ports.in_cache_free_req"
},
{
"cpu.core*.dcache.ports.out_biu_req",
"cpu.core*.dcache.ports.out_l2cache_req",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a L2Cache.md file documenting modeled microarchitcture of L2Cache? Such a document would help in understanding the code, and would enable new users and higher adoption by the community.

For example, it can include:

  • a description of various ports of L2Cache and their intended purpose
  • various structures and pipelines used in L2cache
  • stage by stage behavior of each pipeline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure Arup.

Where should this L2Cache.md file reside?
I already have the info available in the presentation I prepared. Just need to port it over! :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have an opinion on what would be the right place for it. Please feel free to create a dir called 'example_uarch_doc' and populate that with this README.

core/DCache.hpp Outdated Show resolved Hide resolved
@Kunal-Buch
Copy link
Contributor Author

Hello @arupc , @klingaard ,:

I have reviewed all the comments for the pull request above and provided the updates for all of them through the commits listed here.

Is there anything else that remains to be reviewed/updated?
Is it good to be approved for merge? :)

Copy link
Collaborator

@klingaard klingaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thank you for addressing the comments posted.

mss/L2Cache.hpp Outdated Show resolved Hide resolved
@klingaard klingaard merged commit e5afd33 into riscv-software-src:master Dec 6, 2023
2 checks passed
@klingaard
Copy link
Collaborator

@h0lyalg0rithm you might need to see how this impacts your current PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants