-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding L2Cache Model - new sparta Unit #114
Conversation
…HE and sends out miss requests to the BIU
… make regress clean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About half way through... 😄
Co-authored-by: Knute <[email protected]> Signed-off-by: Kunal-Buch <[email protected]>
UnitName remanmed to ArchUnit, and pre-incremnt for counters.
@@ -202,12 +210,28 @@ olympia::CoreTopologySimple::CoreTopologySimple(){ | |||
"cpu.core*.lsu.ports.in_cache_free_req" | |||
}, | |||
{ | |||
"cpu.core*.dcache.ports.out_biu_req", | |||
"cpu.core*.dcache.ports.out_l2cache_req", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a L2Cache.md
file documenting modeled microarchitcture of L2Cache? Such a document would help in understanding the code, and would enable new users and higher adoption by the community.
For example, it can include:
- a description of various ports of L2Cache and their intended purpose
- various structures and pipelines used in L2cache
- stage by stage behavior of each pipeline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure Arup.
Where should this L2Cache.md file reside?
I already have the info available in the presentation I prepared. Just need to port it over! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have an opinion on what would be the right place for it. Please feel free to create a dir called 'example_uarch_doc' and populate that with this README.
from bool to uint32_t + PR comment fixes. make regress clean.
Hello @arupc , @klingaard ,: I have reviewed all the comments for the pull request above and provided the updates for all of them through the commits listed here. Is there anything else that remains to be reviewed/updated? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! Thank you for addressing the comments posted.
@h0lyalg0rithm you might need to see how this impacts your current PR |
-> L2Cache can accept multiple requests from DCache and IL1.
-> Cache functional model used is SimpleDL1.
-> Configurable cache hit latency.
-> Misses are forwarded to BIU and kept are tracked in the local buffer.
-> Miss to the pending cacheline is not sent out to BIU.
-> Backpressure handling for BIU credits.
-> make regress clean.