Prepare tp remove function$ #7206
Conversation
cristianoc
force-pushed
the
remove-function$
branch
2 times, most recently
from
a35e183 to
74a96c9
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Syntax Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.
| Benchmark suite | Current: d862a37 | Previous: e1b7fb7 | Ratio |
|---|---|---|---|
Print Napkinscript.res - time/run |
82.75540905999999 ms |
77.00100409999999 ms |
1.07 |
Parse HeroGraphic.res - time/run |
5.446224026666666 ms |
5.13472718 ms |
1.06 |
This comment was automatically generated by workflow using github-action-benchmark.
cristianoc
force-pushed
the
remove-function$
branch
from
5f25b28 to
6eae5c7
Compare
|
@cristianoc Tested against a real-world project. There is an issue with let isInstanceOfDate: Date.t => bool = %raw("(date) => date instanceof Date")or %%raw("/* eslint-disable react-hooks/exhaustive-deps */")both result in the error |
There are a bunch of tests with |
|
Oh wait Windows was failing and I had to restart that job on CI. Perhaps you had stale CI artefacts if it was not finished yet? |
|
Oh, you're totally right, sorry! I just forgot to clean before build. |
| @@ -36,7 +36,8 @@ external a : ?low:int -> hi:int -> a | |||
| low: a -> int option [@@return undefined_to_opt] | |||
| lowSet : a -> int -> unit | |||
| */ | |||
| let h0 = a(~hi=2, ~low="x") | |||
| let h0 = | |||
| a(~hi=2, ~low="x", ...) | |||
There was a problem hiding this comment.
Formatting is weird here now, but we can investigate that later.
| @@ -1822,8 +1822,14 @@ Resolved opens 2 Completion Completion | |||
| ContextPath Value[withCallback](~a) | |||
| ContextPath Value[withCallback] | |||
| Path withCallback | |||
| Found type for function int | |||
| [] | |||
| Found type for function (~b: int) => int | |||
There was a problem hiding this comment.
This is correct and was not found before.
Remove explicit uses of
function$in preparation for removing the type entirely.