Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make Js.Json.t use Boolean(bool) instead of explicit true/false #6421

Merged
merged 3 commits into from
Oct 4, 2023
Merged

make Js.Json.t use Boolean(bool) instead of explicit true/false #6421

merged 3 commits into from
Oct 4, 2023

Conversation

zth
Copy link
Collaborator

@zth zth commented Oct 3, 2023

Follow up to #6368

cc @DZakh

@zth zth requested a review from cristianoc October 3, 2023 14:16
cristianoc
cristianoc approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that a breaking change?
Guess not as the release is not out and this is new?

@zth
Copy link
Collaborator Author

zth commented Oct 3, 2023

Oh no, you're right, should definitely put this under breaking. Let me fix.

@zth zth merged commit 167c586 into master Oct 4, 2023
14 checks passed
@zth zth deleted the json-t-bool branch October 4, 2023 09:00
@mununki mununki mentioned this pull request Oct 10, 2023
Closed
@fhammerschmidt fhammerschmidt mentioned this pull request Oct 16, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zth @cristianoc