Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Js.Json.t use Boolean(bool) instead of explicit true/false #6421

Merged
merged 3 commits into from
Oct 4, 2023
Merged

make Js.Json.t use Boolean(bool) instead of explicit true/false #6421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3493edf
make Js.Json.t use Boolean(bool) instead of explicit true/false
zth Oct 3, 2023
334213f
changelog
zth Oct 3, 2023
84af679
move changelog entry to breaking changes
zth Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@

#### :boom: Breaking Change
- Add smart printer for pipe-chains. https://github.com/rescript-lang/rescript-compiler/pull/6411 (the formatter will reformat existing code in certain cases)
- `Js.Json.t` now uses `Boolean(bool)` instead of explicit `@as(true) True | @as(false) False`. https://github.com/rescript-lang/rescript-compiler/pull/6421

#### :nail_care: Polish

Expand Down
3 changes: 1 addition & 2 deletions jscomp/others/js_json.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@

@unboxed
type rec t =
| @as(false) False
| @as(true) True
| Boolean(bool)
| @as(null) Null
| String(string)
| Number(float)
Expand Down
3 changes: 1 addition & 2 deletions jscomp/others/js_json.resi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@

@unboxed /** The JSON data structure */
type rec t =
| @as(false) False
| @as(true) True
| Boolean(bool)
| @as(null) Null
| String(string)
| Number(float)
Expand Down