Skip to content

Commit

Permalink
make Js.Json.t use Boolean(bool) instead of explicit true/false (#6421)
Browse files Browse the repository at this point in the history
* make Js.Json.t use Boolean(bool) instead of explicit true/false

* changelog

* move changelog entry to breaking changes
  • Loading branch information
zth authored Oct 4, 2023
1 parent b8c4157 commit 167c586
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@

#### :boom: Breaking Change
- Add smart printer for pipe-chains. https://github.com/rescript-lang/rescript-compiler/pull/6411 (the formatter will reformat existing code in certain cases)
- `Js.Json.t` now uses `Boolean(bool)` instead of explicit `@as(true) True | @as(false) False`. https://github.com/rescript-lang/rescript-compiler/pull/6421

#### :nail_care: Polish

Expand Down
3 changes: 1 addition & 2 deletions jscomp/others/js_json.res
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@

@unboxed
type rec t =
| @as(false) False
| @as(true) True
| Boolean(bool)
| @as(null) Null
| String(string)
| Number(float)
Expand Down
3 changes: 1 addition & 2 deletions jscomp/others/js_json.resi
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@

@unboxed /** The JSON data structure */
type rec t =
| @as(false) False
| @as(true) True
| Boolean(bool)
| @as(null) Null
| String(string)
| Number(float)
Expand Down

0 comments on commit 167c586

Please sign in to comment.