Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix StorageNodeClient.query_catalog(…) signature mismatch #8468

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented Dec 16, 2024

Related

CI is failing on nightly: https://github.com/rerun-io/rerun/actions/runs/12335447188/job/34427482723

What

Seems to be a mismatch between doc strings.

@grtlr grtlr added the exclude from changelog PRs with this won't show up in CHANGELOG.md label Dec 16, 2024
Copy link

github-actions bot commented Dec 16, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
89d78cd https://rerun.io/viewer/pr/8468 +nightly +main

Note: This comment is updated whenever you push a commit.

@grtlr
Copy link
Contributor Author

grtlr commented Dec 16, 2024

@rerun-bot full-check

Copy link

Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing lots of green 🤷🏻

@grtlr grtlr merged commit c439c8a into main Dec 16, 2024
67 of 68 checks passed
@grtlr grtlr deleted the grtlr/fix-ci-catalog branch December 16, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants