Skip to content

Commit

Permalink
Attempt to fix StorageNodeClient.query_catalog(…) signature mismatch (
Browse files Browse the repository at this point in the history
#8468)

### Related

<!--
Include links to any related issues/PRs in a bulleted list, for example:
* Closes #1234
* Part of #1337
-->

CI is failing on `nightly`:
https://github.com/rerun-io/rerun/actions/runs/12335447188/job/34427482723

### What

Seems to be a mismatch between doc strings.

<!--
Make sure the PR title and labels are set to maximize their usefulness
for the CHANGELOG,
and our `git log`.

If you have noticed any breaking changes, include them in the migration
guide.

We track various metrics at <https://build.rerun.io>.

For maintainers:
* To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
* To deploy documentation changes immediately after merging this PR, add
the `deploy docs` label.
-->
  • Loading branch information
grtlr authored Dec 16, 2024
1 parent 4ccfcef commit c439c8a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rerun_py/src/remote.rs
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ pub struct PyStorageNodeClient {

#[pymethods]
impl PyStorageNodeClient {
/// Query the recordings metadata catalog.
/// Get the metadata for all recordings in the storage node.
fn query_catalog(&mut self) -> PyResult<PyArrowType<Box<dyn RecordBatchReader + Send>>> {
let reader = self.runtime.block_on(async {
// TODO(jleibs): Support column projection and filtering
Expand Down

0 comments on commit c439c8a

Please sign in to comment.