Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable remote feature in all pypi builds #8446

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Dec 12, 2024

What

  • Make it so remote is enabled in wheels for release/nightly
  • Still stays off for PRs, etc, to keep build times down
  • Also pypi,extra seemed more clear to me than extra implying pypi

@jleibs jleibs marked this pull request as ready for review December 12, 2024 21:48
@jleibs jleibs added 🐍 Python API Python logging API ⛴ release Related to shipping or publishing exclude from changelog PRs with this won't show up in CHANGELOG.md labels Dec 12, 2024
Copy link

github-actions bot commented Dec 12, 2024

Latest documentation preview deployed successfully.

Result Commit Link
05c96da https://landing-et3g2z2o0-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

Copy link

github-actions bot commented Dec 12, 2024

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
05c96da https://rerun.io/viewer/pr/8446 +nightly +main

Note: This comment is updated whenever you push a commit.

@teh-cmc teh-cmc merged commit 084a1e2 into main Dec 13, 2024
45 of 46 checks passed
@teh-cmc teh-cmc deleted the jleibs/enable_remote branch December 13, 2024 08:15
grtlr pushed a commit that referenced this pull request Dec 13, 2024
### What
- Make it so `remote` is enabled in wheels for release/nightly
- Still stays off for PRs, etc, to keep build times down
- Also `pypi,extra` seemed more clear to me than `extra` implying `pypi`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🐍 Python API Python logging API ⛴ release Related to shipping or publishing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants