Skip to content

Commit

Permalink
Enable remote feature in all pypi builds (#8446)
Browse files Browse the repository at this point in the history
### What
- Make it so `remote` is enabled in wheels for release/nightly
- Still stays off for PRs, etc, to keep build times down
- Also `pypi,extra` seemed more clear to me than `extra` implying `pypi`
  • Loading branch information
jleibs authored Dec 13, 2024
1 parent 4889f85 commit 084a1e2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions rerun_py/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ name = "rerun_bindings" # name of the .so library that the Python module will im
default = ["extension-module"]

## Extra features that aren't ready to be included in release builds yet.
extra = ["pypi", "remote"]
extra = []

## The features we turn on when building the `rerun-sdk` PyPi package
## for <https://pypi.org/project/rerun-sdk/>.
pypi = ["extension-module", "nasm", "web_viewer"]
pypi = ["extension-module", "nasm", "web_viewer", "remote"]

## We need to enable the `pyo3/extension-module` when building the SDK,
## but we cannot enable it when building tests and benchmarks, so we
Expand Down
2 changes: 1 addition & 1 deletion scripts/ci/build_and_upload_wheels.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ def build_and_upload(bucket: Bucket | None, mode: BuildMode, gcs_dir: str, targe
elif mode is BuildMode.PR:
maturin_feature_flags = "--no-default-features --features extension-module"
elif mode is BuildMode.EXTRA:
maturin_feature_flags = "--no-default-features --features extra"
maturin_feature_flags = "--no-default-features --features pypi,extra"

dist = f"dist/{target}"

Expand Down

0 comments on commit 084a1e2

Please sign in to comment.