Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Much nicer looking error and warning messages #8127

Merged
merged 13 commits into from
Nov 14, 2024
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Nov 13, 2024

What

Before

image
image
image

After

image
image
image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

To deploy documentation changes immediately after merging this PR, add the deploy docs label.

@emilk emilk added ui concerns graphical user interface 📺 re_viewer affects re_viewer itself include in changelog 🧑‍🎨 Design Requires UX/UI designer input labels Nov 13, 2024
@Wumpf Wumpf requested review from Wumpf and gavrelina November 13, 2024 16:17
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so pretty! <3

Not fond of the selection color here. Maybe a brighter red instead?
image

@emilk
Copy link
Member Author

emilk commented Nov 14, 2024

image

@emilk emilk merged commit 95b118f into main Nov 14, 2024
37 checks passed
@emilk emilk deleted the emilk/nicer-error-messages branch November 14, 2024 09:03
@gavrelina
Copy link
Member

Adding some ui nits:
image

colors (mostly!) are from the json color alias file
figma link

@Wumpf
Copy link
Member

Wumpf commented Nov 14, 2024

@emilk ⬆️ ⬆️ ⬆️ :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍🎨 Design Requires UX/UI designer input include in changelog 📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve visuals of error messages
3 participants