Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label Background Color Change in Rerun 0.20.0 #8175

Closed
edwardstevenw opened this issue Nov 19, 2024 · 1 comment · Fixed by #8337
Closed

Label Background Color Change in Rerun 0.20.0 #8175

edwardstevenw opened this issue Nov 19, 2024 · 1 comment · Fixed by #8337
Assignees
Labels
🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less 🦟 regression A thing that used to work in an earlier release

Comments

@edwardstevenw
Copy link

Describe the bug

I just moved to rerun 0.20.0 from 0.19.1 and I noticed that there is a change in the background of the labels. Is this change intended? I preferred the old version background color which has a greyish color.

To Reproduce
Steps to reproduce the behavior:

  1. Plot any 3D lines with label, this is my code
rec.log(topicState, rerun::LineStrips3D(generateCameraFrustum())
                .with_colors({color}).with_radii({0.01f})
                    .with_labels({"k" + std::to_string(frame_count) + ":" + std::to_string(frame.getStamp() % 1000)}));

Any 3D lines with label will do.

Expected behavior

I want to know whether this change is intended or not.

Screenshots

Rerun version 0.20.0:
Screenshot from 2024-11-19 16-41-17

Rerun version 0.19.1:
image

Desktop (please complete the following information):

  • OS: Ubuntu 22.04 X86_64

Rerun version
rerun-cli 0.20.0 (default map_view nasm native_viewer release web_viewer) [rustc 1.79.0 (129f3b996 2024-06-10), LLVM 18.1.7] x86_64-unknown-linux-gnu release-0.20.0 2bed90b, built 2024-11-14T15:43:35Z
Video features: av1 default ffmpeg nasm serde

@edwardstevenw edwardstevenw added 👀 needs triage This issue needs to be triaged by the Rerun team 🪳 bug Something isn't working labels Nov 19, 2024
@emilk emilk added 🦟 regression A thing that used to work in an earlier release 🏎️ Quick Issue Can be fixed in a few hours or less and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Dec 5, 2024
@emilk
Copy link
Member

emilk commented Dec 5, 2024

I think I broke this in either

should be easy to revert

@emilk emilk self-assigned this Dec 6, 2024
emilk added a commit that referenced this issue Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants