Revert "Show list of enabled feature with rerun --version"
#7770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5325fd8.
emilk
added
⛴ release
Wumpf
pushed a commit
that referenced
this pull request
Oct 25, 2024
* Reverts #7770 * Re-applies #7744 The revert was because during `cargo publish`, a `Cargo.lock` file materialized, and that made cargo angry: ``` Failed to publish re_sdk: error: failed to verify package tarball Caused by: Source directory was modified by build.rs during cargo publish. Build scripts should not modify anything outside of OUT_DIR. Added: /home/runner/work/rerun/rerun/target/package/re_sdk-0.19.0-alpha.9/Cargo.lock ``` So in this PR we only query about which cargo features if we're NOT in a `cargo publish` build. That should work! We'll know when we next publish some crates :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rerun --version#7744The PR caused the crate publishing step to fail with this message:
(https://github.com/rerun-io/rerun/actions/runs/11350925172/job/31573371223)
I don't know why, and this close to release I don't have time to figure out why.