Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show list of enabled features with rerun --version #7885

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 24, 2024

The revert was because during cargo publish, a Cargo.lock file materialized, and that made cargo angry:

Failed to publish re_sdk:
error: failed to verify package tarball

Caused by:
  Source directory was modified by build.rs during cargo publish. Build scripts should not modify anything outside of OUT_DIR.
  Added: /home/runner/work/rerun/rerun/target/package/re_sdk-0.19.0-alpha.9/Cargo.lock

So in this PR we only query about which cargo features if we're NOT in a cargo publish build. That should work! We'll know when we next publish some crates :)

@emilk emilk changed the title Revert "Revert "Show list of enabled feature with rerun --version"" Show list of enabled feature with rerun --version Oct 24, 2024
@emilk emilk added 🧑‍💻 dev experience developer experience (excluding CI) ⛴ release Related to shipping or publishing include in changelog labels Oct 24, 2024
@emilk emilk marked this pull request as ready for review October 24, 2024 09:06
@Wumpf Wumpf self-requested a review October 24, 2024 11:34
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

crates/build/re_build_info/src/build_info.rs Show resolved Hide resolved
@Wumpf Wumpf merged commit d0b60f9 into main Oct 25, 2024
35 checks passed
@Wumpf Wumpf deleted the revert-7770-revert-7744-emilk/auto-feature-flags branch October 25, 2024 08:35
@emilk emilk changed the title Show list of enabled feature with rerun --version Show list of enabled features with rerun --version Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) include in changelog ⛴ release Related to shipping or publishing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants