Update to latest wgpu and egui/eframe #7218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
🔺 re_renderer
|
FYI I just landed emilk/egui#4964 |
emilk
force-pushed
the
emilk/update-egui-wgpu
branch
from
d6aa3ab to
b530459
Compare
emilk
added
the
exclude from changelog
emilk
force-pushed
the
emilk/update-egui-wgpu
branch
from
5b40076 to
489ab26
Compare
emilk
commented
Aug 28, 2024
| height: 1080, | ||
| }); | ||
|
|
||
| // TODO(emilk): port this to the winit 0.30 API, using maybe https://docs.rs/winit/latest/winit/platform/web/trait.EventLoopExtWebSys.html ? |
There was a problem hiding this comment.
I gave up porting the wasm32 portion of the examples to latest winit
jprochazk
reviewed
Aug 30, 2024
| @@ -195,7 +195,7 @@ export class WebViewer { | |||
|
|
|||
| this.#handle = new WebHandle_class({ ...options, fullscreen }); | |||
| try { | |||
| await this.#handle.start(this.#canvas.id); | |||
There was a problem hiding this comment.
We should also remove all the this.#id shenanigans here, seeing as it's no longer used
abey79
approved these changes
Sep 2, 2024
Comment on lines
+79
to
+80
| // winit 0.30.5 spams about `set_cursor_visible` calls. It's gone on winit master, so hopefully gone in next winit release. | ||
| "winit", |
There was a problem hiding this comment.
We don't really have a system in place for tracking new releases… this is a very minor thing anyways (we rarely care about debug logs from winit)
Comment on lines
+329
to
+330
| let table_builder = egui_extras::TableBuilder::new(ui) | ||
| .id_source(chunk_store.id()) |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
masterbranchThis changes the interface between HTML/JS and WASM from passing a canvas id, to passing the canvas element directly (emilk/egui#4780). This means the preview of this PR is broken, and merging this PR will likely break it for all subsequent PRs. @jprochazk do you have a good idea how we can fix this?TODO
re_rendererexample needs a winit updateChecklist
pixi run rerun-webmainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.