Add wasm-bindgen version check to CI #7983
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
wasm-bindgen
version in CII believe our web viewer was broken since this PR:
There were multiple people reviewing it (including myself with a "Web stuff LGTM" 🤦 ), and yet none of us remembered to check the output of
wasm-bindgen
. We clearly need something to remind us.The new CI check added in this PR will compare the
wasm-bindgen
version to the one onmain
, and require thewasm-bindgen version update
label if they differ. This is vastly better than committing and comparing hashes of the built files, because:wasm-bindgen
changingChecklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.