-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline viewer improvements #6504
Changes from 13 commits
38eb878
170b8be
545a747
fb23a33
5f5caa4
df2b644
ef646b1
a97eacd
23148ed
85c9a15
6e72374
01e9db6
94a7041
4cd8365
350524c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,12 +73,18 @@ impl WebHandle { | |
} | ||
|
||
#[wasm_bindgen] | ||
pub fn toggle_panel_overrides(&self) { | ||
pub fn toggle_panel_overrides(&self, value: Option<bool>) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I find the existence of this API as a toggle (as opposed to just something like I'm glad to see us turning it into a hybrid set/toggle, though the name as toggle still seems like it might hurt discoverability / expectation somewhat. |
||
let Some(mut app) = self.runner.app_mut::<crate::App>() else { | ||
return; | ||
}; | ||
|
||
app.panel_state_overrides_active ^= true; | ||
match value { | ||
Some(value) => app.panel_state_overrides_active = value, | ||
None => app.panel_state_overrides_active ^= true, | ||
} | ||
|
||
// request repaint, because the overrides may cause panels to expand/collapse | ||
app.egui_ctx.request_repaint(); | ||
} | ||
|
||
#[wasm_bindgen] | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,3 +5,5 @@ re_viewer_bg.wasm | |
re_viewer_bg.wasm.d.ts | ||
index.d.ts | ||
index.d.ts.map | ||
index.js | ||
index.js.map |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR since the logic probably adds too much complexity, but I think we may want to reconsider this at some point and have this be something like:
!app_blueprint.selection_panel_hidden()
It would be nice if the state was determine by: