Inline viewer improvements #6504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprochazk
added
🕸️ web
jleibs
approved these changes
Jun 6, 2024
| @@ -73,12 +73,18 @@ impl WebHandle { | |||
| } | |||
|
|
|||
| #[wasm_bindgen] | |||
| pub fn toggle_panel_overrides(&self) { | |||
| pub fn toggle_panel_overrides(&self, value: Option<bool>) { | |||
There was a problem hiding this comment.
I find the existence of this API as a toggle (as opposed to just something like set_panel_overrides_active) to be a bit unexpected.
I'm glad to see us turning it into a hybrid set/toggle, though the name as toggle still seems like it might hurt discoverability / expectation somewhat.
| UICommand::ToggleSelectionPanel.format_shortcut_tooltip_suffix(ui.ctx()) | ||
| )) | ||
| .clicked() | ||
| if !app_blueprint.selection_panel_overridden() |
There was a problem hiding this comment.
Not for this PR since the logic probably adds too much complexity, but I think we may want to reconsider this at some point and have this be something like: !app_blueprint.selection_panel_hidden()
It would be nice if the state was determine by:
- If hidden, never show it -- no UI controls.
- If user has interacted with the controls, use that value.
- If overridden from JS, apply that value.
- If the blueprint has a value, apply that value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
web-viewerpackage to TypeScript (from JS + JSDoc)WebViewer:fullscreenreadyAnimations across updates to
positiondon't really work that properly. I had to hack around it in this PR by usingsetTimeout/requestAnimationFrameto give the browser a chance to update thepositionCSS property before updating any other styles.Preview:
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerTo run all checks from
main, comment on the PR with@rerun-bot full-check.