Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove to archetype & archetype queries #6501

Merged
merged 9 commits into from
Jun 5, 2024
Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jun 5, 2024

What

This removes a fair bit of generated code that we use in too few places to justify the overhead!

commit by commit review recommended: Each commit removes a use of latest_at_archetype (or similar), the last then removes the then freed up ToArchetype machinery.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md do-not-merge Do not merge this PR labels Jun 5, 2024
@Wumpf Wumpf force-pushed the andreas/remove-to-archetype branch 2 times, most recently from 733cff7 to cc8fc7d Compare June 5, 2024 13:45
Base automatically changed from andreas/cleanup-property-querying to main June 5, 2024 14:24
@Wumpf Wumpf force-pushed the andreas/remove-to-archetype branch from cc8fc7d to 7c938a6 Compare June 5, 2024 14:24
@Wumpf Wumpf removed the do-not-merge Do not merge this PR label Jun 5, 2024
@Wumpf Wumpf merged commit 7b30934 into main Jun 5, 2024
34 of 36 checks passed
@Wumpf Wumpf deleted the andreas/remove-to-archetype branch June 5, 2024 14:35
emilk added a commit that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants