-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove to archetype & archetype queries #6501
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🚜 refactor
Change the code, not the functionality
exclude from changelog
PRs with this won't show up in CHANGELOG.md
do-not-merge
Do not merge this PR
labels
Jun 5, 2024
Wumpf
force-pushed
the
andreas/remove-to-archetype
branch
2 times, most recently
from
June 5, 2024 13:45
733cff7
to
cc8fc7d
Compare
jleibs
approved these changes
Jun 5, 2024
Wumpf
force-pushed
the
andreas/remove-to-archetype
branch
from
June 5, 2024 14:24
cc8fc7d
to
7c938a6
Compare
1 task
emilk
added a commit
that referenced
this pull request
Jun 10, 2024
![image](https://github.com/rerun-io/rerun/assets/1148717/3d02590b-b1e8-42b4-8dcf-cc397798de71) * Spam was added in #6501 * [x] Spam is now gone --------- Co-authored-by: Jeremy Leibs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
exclude from changelog
PRs with this won't show up in CHANGELOG.md
🚜 refactor
Change the code, not the functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This removes a fair bit of generated code that we use in too few places to justify the overhead!
commit by commit review recommended: Each commit removes a use of latest_at_archetype (or similar), the last then removes the then freed up ToArchetype machinery.
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.