Reduce log spam about missing ContainerKind component (#6526)

![image](https://github.com/rerun-io/rerun/assets/1148717/3d02590b-b1e8-42b4-8dcf-cc397798de71) * Spam was added in #6501 * [x] Spam is now gone --------- Co-authored-by: Jeremy Leibs <[email protected]>
rerun-io · Jun 10, 2024 · 49ab9c4 · 49ab9c4
1 parent e2cb396
commit 49ab9c4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 12 deletions.
diff --git a/crates/re_viewport_blueprint/src/container.rs b/crates/re_viewport_blueprint/src/container.rs
@@ -56,10 +56,12 @@ impl ContainerBlueprint {
                 .iter()
                 .copied(),
         );
-        let Some(container_kind) = results.get_instance::<ContainerKind>(resolver, 0) else {
-            re_log::error!("Container {id:?} is lacking the required `ContainerKind` component.");
-            return None;
-        };
+
+        // This is a required component. Note that when loading containers we crawl the subtree and so
+        // cleared empty container paths may exist transiently. The fact that they have an empty container_kind
+        // is the marker that the have been cleared and not an error.
+        let container_kind = results.get_instance::<ContainerKind>(resolver, 0)?;
+
         let blueprint_archetypes::ContainerBlueprint {
             container_kind,
             display_name,

diff --git a/crates/re_viewport_blueprint/src/space_view.rs b/crates/re_viewport_blueprint/src/space_view.rs
@@ -133,14 +133,11 @@ impl SpaceViewBlueprint {
                 .copied(),
         );
 
-        let Some(class_identifier) =
-            results.get_instance::<blueprint_components::SpaceViewClass>(resolver, 0)
-        else {
-            re_log::error!(
-                "View blueprint at {id:?} is lacking the required `SpaceViewClass` component."
-            );
-            return None;
-        };
+        // This is a required component. Note that when loading space-views we crawl the subtree and so
+        // cleared empty space-views paths may exist transiently. The fact that they have an empty class_identifier
+        // is the marker that the have been cleared and not an error.
+        let class_identifier =
+            results.get_instance::<blueprint_components::SpaceViewClass>(resolver, 0)?;
 
         let blueprint_archetypes::SpaceViewBlueprint {
             class_identifier,