Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hunting down zombie TODOs: script + clean up #3405

Merged
merged 5 commits into from
Sep 22, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ci step
  • Loading branch information
teh-cmc committed Sep 22, 2023
commit 678511c9b5189902a32515edc17a2cace486a56b
4 changes: 4 additions & 0 deletions .github/workflows/reusable_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,10 @@ jobs:
run: |
./scripts/lint.py

- name: Check for zombie TODOs
run: |
./scripts/zombie_todos.py --token ${{ secrets.GITHUB_TOKEN }}

- name: Check for too large files
run: |
./scripts/ci/check_large_files.sh
Expand Down
7 changes: 5 additions & 2 deletions scripts/ci/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,14 @@
-r ../../rerun_py/requirements-lint.txt

Jinja2==3.1.2
Pillow==10.0.0
PyGithub==1.59.0

aiohttp==3.8.5
colorama==0.4.6
gitignore-parser==0.1.4
google-cloud-storage==2.9.0
packaging==23.1
python-frontmatter==1.0.0
requests>=2.31,<3
tomlkit==0.11.8
python-frontmatter==1.0.0
Pillow==10.0.0
1 change: 1 addition & 0 deletions scripts/lint.py
Original file line number Diff line number Diff line change
Expand Up @@ -621,6 +621,7 @@ def main() -> None:
extensions = ["c", "cpp", "fbs", "h", "hpp" "html", "js", "md", "py", "rs", "sh", "toml", "txt", "wgsl", "yml"]

exclude_paths = {
"./.github/workflows/reusable_checks.yml", # zombie TODO hunting job
"./CODE_STYLE.md",
"./crates/re_types_builder/src/reflection.rs", # auto-generated
"./examples/rust/objectron/src/objectron.rs", # auto-generated
Expand Down
1 change: 0 additions & 1 deletion scripts/requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,3 @@ tqdm
requests
gitignore_parser # handle .gitignore
python-frontmatter==1.0.0
aiohttp