Hunting down zombie TODOs: script + clean up #3405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
force-pushed
the
cmc/zombie_todos
branch
2 times, most recently
from
909ace2 to
f0e300a
Compare
|
I'll clean these so we can get back to a clean slate, then disable the CI step. |
teh-cmc
force-pushed
the
cmc/zombie_todos
branch
from
8d44f48 to
6d98656
Compare
|
CI passes, now we disable it for now. |
teh-cmc
added
the
exclude from changelog
teh-cmc
changed the title
emilk
approved these changes
Sep 22, 2023
teh-cmc
force-pushed
the
cmc/zombie_todos
branch
from
dcaa867 to
1e9fafe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added script to hunt down zombie issues, and fixed all existing ones.
This does not run on CI; run it manually yourself with:
What
Checklist