-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Examples page to the Welcome Screen #3191
Conversation
Size changes
|
# Conflicts: # scripts/ci/build_demo_app.py
I looks amazing 😍 But clicking one feels extremely unresponsive, as there is no indication that your click came through. As you noted before, we need to add a load-screen asap.
In other words, I believe this needs an if self.should_show_welcome_screen(&mut store_hub) {
store_hub.set_app_id(StoreHub::welcome_screen_app_id());
} |
@emilk I gave it a quick try but.... it's not that simple (I got all sorts of weird behaviour whose fixing feels beyond the scope of this PR). For the purpose of this PR, I'd like to give some kind of visual feedback (some flashing?) to indicate that the click has been registered, and address the progress feedback in a follow-up PR. |
@martenbjork thanks for the detailed feedback—will try to implement as much as possible. On font weight: I don't believe egui currently has support for font weight (emilk/egui#3218), so we're stuck with whatever is the default. |
Also, I understand the "copy to tags" vertical space and the "32px vertical gap" to be minimal values, as the effective gap depends on the corresponding thumbnail aspect ratio (tags are grid aligned too). |
Yes! 💯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it, but I suggest we wait for emilk/egui#3297 to be merged (any minute now) and the update the PR to use it.
emilk/egui#3297 has been merged, and this would be the perfect PR to test it on! The new API is: // during setup
egui_extras::loaders::install(&egui_ctx);
// when you want to load an image
ui.image2("http://link.to.image.com/image.png"); Will also need to enable some features on |
@jprochazk I'll get on it this afternoon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
### What This PR: - implements a refreshed, toned-down Welcome Page; - add the panel linking to the examples page; - make the UI responsive. This is a PR train, #3191 must be reviewed/fixed/merged first. Fixes: - #3124 - #3043 <img width="1608" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/28e68d38-2efa-41ab-96a0-2891bee59ea3"> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3219) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/3219) - [Docs preview](https://rerun.io/preview/53fef8c10871100e6aef8a2e49aff9d28e6cac6f/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/53fef8c10871100e6aef8a2e49aff9d28e6cac6f/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/) --------- Co-authored-by: Emil Ernerfeldt <[email protected]>
What
Add Example page to the Welcome Screen.
Note
This PR bakes in the example thumbnails, which will incur a significant bump in the wasm build. We will remove this once we pull thumbnails from the web using emilk/egui#3291.Fixes #3096
TODO
Not included in this PR
Checklist