Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REMINDER-0.9] Make sure baked-in example manifest is correct #3213

Closed
abey79 opened this issue Sep 5, 2023 · 2 comments
Closed

[REMINDER-0.9] Make sure baked-in example manifest is correct #3213

abey79 opened this issue Sep 5, 2023 · 2 comments
Labels
⛴ release Related to shipping or publishing
Milestone
0.9 - Codegen, Ty...

Comments

@abey79
Copy link
Member

abey79 commented Sep 5, 2023

This is a reminder issue to ensure that we don't ship 0.9 with the wrong example manifest, as the related infrastructure is still being put in place.

#3191 introduced an in-app example page that uses a baked-in example_manifest.json containing, in particular, links to RRD. We must make sure that these links are "correct" (ie. pointing to RRD built along with the release) for the release executables.

This should be addressed by #3212 and #3190 down the line, but it's likely that this will require manual work for 0.9. This this reminder issue.
@abey79 abey79 added the ⛴ release Related to shipping or publishing label Sep 5, 2023
@abey79 abey79 mentioned this issue Sep 5, 2023
Merged
6 tasks
abey79 added a commit that referenced this issue Sep 6, 2023
@abey79 @emilk
Add Examples page to the Welcome Screen (#3191)
cb197a2 
### What

Add Example page to the Welcome Screen.


Fixes #3096 

<img width="1366" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/bbe2e84e-9ade-4da8-b095-d7b0f396c26f">

### TODO

- [x] fix layout issues
- [x] display tags
- [x] have dedicated, short copy for the description: #3201

### Not included in this PR

- **WARNING**: here, we bake in a manifest with hard-coded links to RRDs
that were generated within this PR. This will lead to issue down the
line, when the RRD format changes.
  - #3212
  - #3213
- download updated manifest
  -  #3190 
- load thumbnail from the web
  - emilk/egui#3291
- provide feedback while downloading a RRD
  - #3192

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3191) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3191)
- [Docs
preview](https://rerun.io/preview/3be107e4cc6aa6758a3f22c27a79233b33f2ea6b/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/3be107e4cc6aa6758a3f22c27a79233b33f2ea6b/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)

---------

Co-authored-by: Emil Ernerfeldt <[email protected]>
@emilk
Copy link
Member

emilk commented Sep 24, 2023

I think this is fixed by #3332, right @jprochazk ?

@emilk
Copy link
Member

emilk commented Sep 25, 2023

@emilk emilk closed this as completed Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⛴ release Related to shipping or publishing
Projects
None yet
Milestone
0.9 - Codegen, Type Oriented Api
Development

No branches or pull requests
2 participants
@emilk @abey79