Support HDR video (shows wrong color or glitches today) #7594
Labels
Comments
|
Can we detect HDR videos and log a warning about it? |
|
given that for all these cases I see BT.2020 (instead of (SDR) BT.709) on the "media information" in VLC, I suspect that this is a piece of information provided by mp4 🤔 . In any case, yes there gotta be some way and a warning would be in order! |
6 tasks
emilk
added a commit
that referenced
this issue
Oct 8, 2024
### What * Uses rerun-io/re_mp4#10 Improves the video blob info in two ways: * Adds bit depth (if known) * Shows human-redable name of codec (e.g. AV1 or H.264)    A warning will also be printed if trying to decode a HDR video (since we don't yet support that). Related: * #7594 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7633?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7633?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7633) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
|
For reference: We do warn by now in a few places. In some even about the technically distinct cases of:
(the distinction is kinda silly, but it looks like depending on the format it's real!) |
This was referenced Nov 2, 2024
emilk
added a commit
that referenced
this issue
Nov 2, 2024
### What * Closes #7973 * Part of #7594 Review with ignoring whitespace changes #### Before <img width="1639" alt="Screenshot 2024-11-02 at 12 02 13" src="https://github.com/user-attachments/assets/500e5b10-c82f-483b-9e2d-c5cc75f29e52"> #### After <img width="1639" alt="Screenshot 2024-11-02 at 12 00 59" src="https://github.com/user-attachments/assets/c7067210-bb47-4cf7-8633-30a8b3edb42a"> #### VLC (for reference) <img width="1552" alt="Screenshot 2024-11-02 at 16 43 10" src="https://github.com/user-attachments/assets/f85be55c-3878-4fa0-b6fd-3b54f015622a"> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7978?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7978?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7978) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. --------- Co-authored-by: Andreas Reich <[email protected]>
turns out it is not! As demonstrated there's high bit depth Bt709 video material out there! See #7973 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some of it might be shortcomings in the (web) decoder, but we need to take a more serious look at this. Meanwhile HDR/BT.2020 video should not be supported.
Firefox @ Mac on av1
Chrome @ Mac on the same video
(colors are still wrong)
AV1 native:
Possibly related to:
The text was updated successfully, but these errors were encountered: