Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve video information on select, warn on HDR content #7633

Merged
merged 8 commits into from
Oct 8, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Oct 8, 2024

What

Improves the video blob info in two ways:

  • Adds bit depth (if known)
  • Shows human-redable name of codec (e.g. AV1 or H.264)

Screenshot 2024-10-08 at 15 25 24

Screenshot 2024-10-08 at 15 25 35

Screenshot 2024-10-08 at 15 27 41

A warning will also be printed if trying to decode a HDR video (since we don't yet support that).

Related:

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added do-not-merge Do not merge this PR exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video labels Oct 8, 2024
@Wumpf Wumpf changed the title Convert re_mp4::Time -> std::time::Duration Improve video information on select, warn on HDR content Oct 8, 2024
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

crates/store/re_video/src/demux/mod.rs Show resolved Hide resolved
crates/store/re_video/src/demux/mod.rs Outdated Show resolved Hide resolved
Base automatically changed from emilk/refactor-video-decoders to main October 8, 2024 13:21
An error occurred while trying to automatically change base from emilk/refactor-video-decoders to main October 8, 2024 13:21
@emilk emilk force-pushed the emilk/better-video-info branch from a4d7ecc to dac42a2 Compare October 8, 2024 13:22
@emilk emilk removed the do-not-merge Do not merge this PR label Oct 8, 2024
@emilk emilk force-pushed the emilk/better-video-info branch from dac42a2 to 15b98f1 Compare October 8, 2024 13:27
@emilk emilk merged commit ba5bfe9 into main Oct 8, 2024
33 of 34 checks passed
@emilk emilk deleted the emilk/better-video-info branch October 8, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🎞️ video
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants